Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix amd64 support #447

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix amd64 support #447

merged 2 commits into from
Jan 29, 2025

Conversation

michael-yuji
Copy link
Member

Fix when "${CMAKE_SYSTEM_PROCESSOR}" is lowercase "amd64"

@michael-yuji michael-yuji added the bug Something isn't working label Jan 24, 2025
lorentey
lorentey requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks!

I think we'll want to ship this in the near future (in version 1.2); would you please retarget this on top of the release/1.2 branch, rather than on main?

@lorentey lorentey added this to the 1.2.0 milestone Jan 27, 2025
@michael-yuji michael-yuji changed the base branch from main to release/1.2 January 27, 2025 23:10
@michael-yuji michael-yuji changed the base branch from release/1.2 to main January 27, 2025 23:10
@michael-yuji michael-yuji changed the base branch from main to release/1.2 January 27, 2025 23:13
@michael-yuji michael-yuji requested a review from lorentey January 28, 2025 11:49
@lorentey lorentey merged commit 0c11f09 into apple:release/1.2 Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorentey lorentey lorentey approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-yuji @lorentey